Store Testing Framework Solidity and Yul #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauravahuja
force-pushed
the
chore/solidity-testing-framework
branch
from
48c7e3f to
e6ca2b5
Compare
DavePearce
approved these changes
Oct 3, 2024
| private static final ObjectMapper objectMapper = new ObjectMapper(); | ||
| private static final ClassLoader classLoader = SolidityUtils.class.getClassLoader(); | ||
|
|
||
| public static Bytes getContractByteCode(Class<? extends Contract> contractClass) { |
There was a problem hiding this comment.
I'm not super clear on what's happening here. I think it would be helpful to write some amount of documentation to explain (at a high level) what's going on.
There was a problem hiding this comment.
Added some documentation for this method.
powerslider
reviewed
Oct 3, 2024
arithmetization/src/test/java/net/consensys/linea/zktracer/ExampleSolidityTest.java
Outdated
Show resolved
Hide resolved
powerslider
reviewed
Oct 3, 2024
arithmetization/src/test/java/net/consensys/linea/zktracer/ExampleSolidityTest.java
Outdated
Show resolved
Hide resolved
powerslider
reviewed
Oct 3, 2024
arithmetization/src/test/java/net/consensys/linea/zktracer/ExampleSolidityTest.java
Outdated
Show resolved
Hide resolved
powerslider
reviewed
Oct 3, 2024
| import org.web3j.tx.Contract; | ||
|
|
||
| public class SolidityUtils { | ||
| private static final ObjectMapper objectMapper = new ObjectMapper(); |
There was a problem hiding this comment.
I recommend using here JsonConverter class the embeds the ObjectMapper and offers some helpful functionalities.
There was a problem hiding this comment.
The API for JsonConverter requires the Class that can parsed from the json file. I do not have a Class for that, I am interested in just one particular attribute 'bin-runtime' of a specific contract in the json file.
powerslider
reviewed
Oct 3, 2024
testing/src/main/java/net/consensys/linea/testing/SolidityUtils.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1139